Skip to content

Deserialization error

Jonathan Cooper requested to merge DCDEV-88-deserialization-error into develop

ServiceAgreementQualityService.java was throwing a json path MappingException, which arose from trying to map List keywords to String when parsing the service agreement json. This was being logged when a keyword was added and saved in the editor. However, all subsequent checks weren't executed and so no it appeared as though there were no errors in the document - which was incorrect.

ServiceAgreementQualityService.java was edited so that basicChecks() could handle lists as well as strings. The check for a list is quite basic and just looks for a non-zero list. It could be made more granular to look for values, but the current solution good enough.

There were also 4 keyword checks that were redundant (Instrument keywords, Place keywords, Observed properties keywords and Project keywords) and have been removed

Closes DCDEV-88

Merge request reports